Birmingham | ITP-Jan | Roman Sanaye | Sprint 1 | Sprint 1 Exercises#996
Open
RomanSanaye wants to merge 12 commits intoCodeYourFuture:mainfrom
Open
Birmingham | ITP-Jan | Roman Sanaye | Sprint 1 | Sprint 1 Exercises#996RomanSanaye wants to merge 12 commits intoCodeYourFuture:mainfrom
RomanSanaye wants to merge 12 commits intoCodeYourFuture:mainfrom
Conversation
RomanSanaye
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
8 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RomanSanaye
changed the title
RomanSanaye
added
the
Needs Review
Poonam-raj
added
Review in progress
RomanSanaye
added
Needs Review
Poonam-raj
reviewed
Mar 20, 2026
Poonam-raj
left a comment
Poonam-raj
left a comment
There was a problem hiding this comment.
Great work with a few things I'd like to see corrected before approving this work.
common themes that need improving include
- variables being let vs const - which variables can be made stricter without breaking the code?
- leaving in commented code
I also spotted a few areas where tests were not accurate to the behaviours expected.
Poonam-raj
added
Reviewed
RomanSanaye
added
the
Needs Review
Poonam-raj
added
Review in progress
Poonam-raj
reviewed
Mar 23, 2026
Poonam-raj
reviewed
Mar 23, 2026
Poonam-raj
left a comment
Poonam-raj
left a comment
There was a problem hiding this comment.
Generally you have addressed my points but some slight inaccuracies. Please make the final amendments and then we are done :D
Poonam-raj
added
Reviewed
Poonam-raj
reviewed
Mar 23, 2026
Comment on lines
+40
to
+43
| test("decimal number should return the correct total", () => { | ||
| let elements = [1, 2.3, 4.5, 6]; | ||
| expect(sum(elements)).toEqual(13.8); | ||
| }); |
Poonam-raj
reviewed
Mar 23, 2026
Comment on lines
+56
to
+59
| test("non-number values should return Zero", () => { | ||
| let elements = ["a", "d", "hi"]; | ||
| expect(sum(elements)).toEqual(0); | ||
| }); |
Poonam-raj
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This pull request includes my solutions for the Sprint 1 exercises in the Module Data-Groups.
I implemented the
finalFrequencyfunction which calculates the resulting frequency after applying all frequency changes from the input list.The function processes the input numbers and computes the final frequency using JavaScript.
Questions
Is my implementation clear and readable, or would you suggest any improvements to the logic or structure?